Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widescreen toggle #94

Draft
wants to merge 4 commits into
base: develop/2.1.0
Choose a base branch
from

Conversation

recardo-7
Copy link
Contributor

Add a toggle for widescreen in the start menu

@Yanis002
Copy link
Collaborator

Yanis002 commented Apr 21, 2024

I know this is a draft but my first suggestion would be using the mod_assets folder since it's there now, instead of commiting the vanilla files, second I just wanna say we talked about how it would be nice to have a page 2 in the options of the file select, not saying you should do it of course, I have that on my todo list

@Reonu
Copy link

Reonu commented Apr 22, 2024

Yeah definitely commit the assets to the mod_assets folder. Files placed in the normal assets folder will be deleted after a make distclean even if they were commited into git.

@Reonu
Copy link

Reonu commented Apr 24, 2024

while this is cool, I've been thinking about the fact that HackerOoT has multilang support since it's based on PAL, but since it's the GameCube version, it's just missing the UI for it. The language select in PAL replaces the brightness option.

So wouldn't it make more sense to have a define to replace brightness with language select, rather than putting the aspect ratio option there? And then there can be a second page, like Yanis suggested, to place all non-vanilla options, such as this widescreen one.

What do you think?

@Yanis002 Yanis002 added the 2.1.0 label May 17, 2024
@ariahiro64
Copy link
Collaborator

i think it could be on the side like my character select in cg
however my code is shitty and should be rewritten if used in hackeroot
already removed it temporarily anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants